fix: remove process flakes commit_sha arg#1199
Conversation
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 456 456
Lines 37053 37044 -9
=======================================
- Hits 36201 36194 -7
+ Misses 852 850 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| log.info( | ||
| "Received process flakes task", | ||
| extra=dict(repoid=repo_id, commit=commit_id), | ||
| extra=dict(repoid=repo_id), |
There was a problem hiding this comment.
Do you still want to log the possible commit_shas?
There was a problem hiding this comment.
as the repo_id (along with name, and owner info) is part of the log context now, I don’t think we need to add this context explicitly at all.
| log.info( | ||
| "Received process flakes task", | ||
| extra=dict(repoid=repo_id, commit=commit_id), | ||
| extra=dict(repoid=repo_id), |
There was a problem hiding this comment.
as the repo_id (along with name, and owner info) is part of the log context now, I don’t think we need to add this context explicitly at all.
this is the final step in moving the process flakes task to using the new method of fetching commit shas from redis. Since all TA finisher tasks are writing to redis using the new method, the process flakes task doesn't need to read the old method anymore, so we can remove that.
joseph-sentry
force-pushed
the
joseph/flake-args-1
branch
from
b112e47 to
97dd9ec
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
3 participants
this is the final step in moving the process flakes task to using the new method of fetching commit shas from redis. Since all TA finisher tasks are writing to redis using the new method, the process flakes task doesn't need to read the old method anymore, so we can remove that.